doc, cmd: Tweak the wording and error messages for consistency#1767
Conversation
The useradd(8) and usermod(8) manuals use the term 'login shell', except one instance in useradd(8) where it says 'default login shell' [1,2]. The toolbox-init-container(1) manual and the 'init-container' command already use 'login shell', and it's shorter than 'default shell'. So, it wins. Fallout from the following: * 6c86cab * 59055cf * 662bd89 * 8f30d71 [1] https://man7.org/linux/man-pages/man8/useradd.8.html [2] https://man7.org/linux/man-pages/man8/usermod.8.html containers#1767
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the terminology used for user shells across both documentation and command-line error messages. By consistently using "login shell" instead of "default shell," the project aligns with established Linux manual pages like Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
593da55 to
e003a4e
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 13s |
The
useradd(8)andusermod(8)manuals use the term login shell, except one instance inuseradd(8)where it says default login shell [1,2]. Thetoolbox-init-container(1)manual and theinit-containercommand already use login shell, and it's shorter than default shell. So, it wins.Fallout from the following:
[1] https://man7.org/linux/man-pages/man8/useradd.8.html
[2] https://man7.org/linux/man-pages/man8/usermod.8.html