Skip to content

doc, cmd: Tweak the wording and error messages for consistency#1767

Merged
debarshiray merged 1 commit intocontainers:mainfrom
debarshiray:wip/rishi/cmd-create-enter-rootMigration-default-login-shell-rename
Mar 6, 2026
Merged

doc, cmd: Tweak the wording and error messages for consistency#1767
debarshiray merged 1 commit intocontainers:mainfrom
debarshiray:wip/rishi/cmd-create-enter-rootMigration-default-login-shell-rename

Conversation

@debarshiray
Copy link
Member

The useradd(8) and usermod(8) manuals use the term login shell, except one instance in useradd(8) where it says default login shell [1,2]. The toolbox-init-container(1) manual and the init-container command already use login shell, and it's shorter than default shell. So, it wins.

Fallout from the following:

[1] https://man7.org/linux/man-pages/man8/useradd.8.html

[2] https://man7.org/linux/man-pages/man8/usermod.8.html

The useradd(8) and usermod(8) manuals use the term 'login shell', except
one instance in useradd(8) where it says 'default login shell' [1,2].
The toolbox-init-container(1) manual and the 'init-container' command
already use 'login shell', and it's shorter than 'default shell'.  So,
it wins.

Fallout from the following:
  * 6c86cab
  * 59055cf
  * 662bd89
  * 8f30d71

[1] https://man7.org/linux/man-pages/man8/useradd.8.html

[2] https://man7.org/linux/man-pages/man8/usermod.8.html

containers#1767
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the terminology used for user shells across both documentation and command-line error messages. By consistently using "login shell" instead of "default shell," the project aligns with established Linux manual pages like useradd(8) and usermod(8), improving clarity and consistency for users.

Highlights

  • Documentation Update: The doc/toolbox-enter.1.md file was updated to replace "default shell" with "login shell" for improved consistency.
  • Error Message Consistency: Error messages across src/cmd/create.go, src/cmd/enter.go, and src/cmd/rootMigrationPath.go were updated to refer to "login shell" instead of "default shell".

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • doc/toolbox-enter.1.md
    • Updated the description to use "login shell" instead of "default shell".
  • src/cmd/create.go
    • Modified the error message for when the user's shell cannot be retrieved, changing "default shell" to "login shell".
  • src/cmd/enter.go
    • Modified the error message for when the user's shell cannot be retrieved, changing "default shell" to "login shell".
  • src/cmd/rootMigrationPath.go
    • Modified the error message for when the user's shell cannot be retrieved, changing "default shell" to "login shell".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@debarshiray debarshiray force-pushed the wip/rishi/cmd-create-enter-rootMigration-default-login-shell-rename branch from 593da55 to e003a4e Compare March 6, 2026 20:34
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the terminology from 'default shell' to 'login shell' across documentation and error messages for consistency. The changes are straightforward and align with the stated goal. I have reviewed the code and found no issues.

@softwarefactory-project-zuul
Copy link

@debarshiray debarshiray merged commit e003a4e into containers:main Mar 6, 2026
3 checks passed
@debarshiray debarshiray deleted the wip/rishi/cmd-create-enter-rootMigration-default-login-shell-rename branch March 6, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant