Skip to content

Comments

fix(bwrap): close pdeathsig parent race#730

Open
danielchristiancazares wants to merge 1 commit intocontainers:mainfrom
danielchristiancazares:fix/pdeathsig-race-check
Open

fix(bwrap): close pdeathsig parent race#730
danielchristiancazares wants to merge 1 commit intocontainers:mainfrom
danielchristiancazares:fix/pdeathsig-race-check

Conversation

@danielchristiancazares
Copy link

Summary

  • capture parent PID before calling prctl(PR_SET_PDEATHSIG, SIGKILL)
  • close the documented race window by re-checking parent PID immediately after prctl
  • self-terminate if parent changed before PDEATHSIG could be installed

Testing

  • meson test -C _builddir_ubuntu --print-errorlogs
    • 4 OK, 0 FAIL, 1 SKIP

Capture parent pid before PR_SET_PDEATHSIG and exit if parent changed after prctl.
@swick
Copy link
Contributor

swick commented Feb 23, 2026

This needs a lot more explanation, including what the race actually is, why _exit is used, why it calls kill on itself instead of relying on exit. The PR description also suspiciously looks vibe-coded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants