Fix case handling for various capitalization issues#2478
Open
vikivivi wants to merge 1 commit intocodespell-project:mainfrom
Open
Fix case handling for various capitalization issues#2478vikivivi wants to merge 1 commit intocodespell-project:mainfrom
vikivivi wants to merge 1 commit intocodespell-project:mainfrom
Conversation
Collaborator
|
@peternewman please review at your convenience |
Collaborator
0535c1f to
ba2a4e8
Compare
Contributor
Author
|
@peternewman I have Git rebase my PR branch and generalise #2223 test infrastructure for various case handling checks. The test case from #2223 is re-adapted to this generalised function. All my test cases are added as well. |
|
I'd be interested in the capabilities that this MR brings in - as I'd like to be able to check/correct capitalization (e.g. |
ba2a4e8 to
3fc7edb
Compare
11ade34 to
6461d20
Compare
* Fix multi words capitalization, camelCase, proper nouns, abbreviation * Do not change suggested words in dictionary to lower case during build_dict() * Capitalization decision is decided in fix_case()
a67ff67 to
dc283f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_dict()fix_case()Below is my basic simple
test.shand mydictionary_test.txt