-
Notifications
You must be signed in to change notification settings - Fork 37
Add task detail view with navigation, messaging, and log history #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EhabY
wants to merge
6
commits into
tasks/list-ui
Choose a base branch
from
tasks/detail-view
base: tasks/list-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f3ab70 to
5a3c6ae
Compare
07d17be to
23e1504
Compare
5a3c6ae to
d21133d
Compare
8fdc5f0 to
686ede3
Compare
e7e96f8 to
4cafe0a
Compare
4cafe0a to
38479a6
Compare
0302286 to
508db63
Compare
aa6e31c to
86aac04
Compare
Adds the task detail view layer including: Components: - TaskDetailView as the main detail view container - TaskDetailHeader with back button, status, and action menu - AgentChatHistory for displaying task log entries with scroll tracking - TaskInput with pause button and state-aware placeholder - ErrorBanner for displaying task errors with link to logs App.tsx enhancements: - Navigation between task list and detail view (inline in Task History) - Selected task state persistence and validation - Adaptive polling intervals based on task state (active vs idle) - Real-time log streaming via logsAppend push messages - refs to avoid stale closures in message handlers - Transition animation when switching views Config additions: - TASK_ACTIVE_INTERVAL_MS for faster updates when task is working - TASK_IDLE_INTERVAL_MS for slower updates when task is idle/complete Also adds codicons CSS import for icon rendering.
- Use plain div for history section to enable flex layout that pins header and input while chat scrolls via inner VscodeScrollable - Add useFollowScroll hook supporting both VscodeScrollable (scrollPos/scrollMax API) and plain scrollable divs - Extract LogEntry component with user/agent role labels and styled message groups - Restyle error banner with color-mixed --vscode-errorForeground
86aac04 to
7ca43c9
Compare
f02beeb to
565ebe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a task in the list now navigates to a detail page with header, log history, and message input.
Components
useFollowScrollHooks
Other changes
sendTaskMessagepromoted from command to request (now returns a response)canSendMessageadded toTaskPermissionstaskDetails()test factory and Proxy-baseduseTasksApimock for cleaner tests