fix: substitute devcontainer.json build args into Dockerfile ARG variables#490
Draft
fix: substitute devcontainer.json build args into Dockerfile ARG variables#490
Conversation
…ables (#455) ImageFromDockerfile and UserFromDockerfile now accept external build args from devcontainer.json, allowing them to override ARG defaults and supply values for ARGs without defaults. This fixes the error when a Dockerfile uses ARG VARIANT + FROM ...${VARIANT} with the value provided in devcontainer.json build.args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
Problem
When
devcontainer.jsonspecifies build args (e.g."VARIANT": "3.11-bookworm") and the Dockerfile usesARG VARIANT+FROM ...${VARIANT}, envbuilder fails becauseImageFromDockerfileandUserFromDockerfiledon't accept external build args — they only use ARG defaults from the Dockerfile itself.Changes
ImageFromDockerfile— AddedbuildArgs []stringparameter. Build args now override ARG defaults and supply values for ARGs without defaults.UserFromDockerfile— AddedbuildArgs []stringparameter. Collects ARG values with build arg overrides and substitutes them intostage.BaseNamebefore parsing image refs.