fix: Hardcoded CSP Nonce Tags in ResponseTrait #9937
+135
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
the
bug
paulbalandan
reviewed
Feb 8, 2026
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
The tests don't make sense. You should be testing instead the behavior when the response is sent when CSP is not enabled.
| $this->{$this->directives[$directive]} = []; | ||
| } | ||
|
|
||
| public function clearNoncePlaceholders(string $text): string |
Member
There was a problem hiding this comment.
- This can go instead in the generateNonces method in the preg_replace_callback so that if $CSPEnabled is false it just returns
''. - In
buildHeaders, if CSP is disabled, just return - In ResponseTrait, remove the conditional and retain the finalize call.
| $this->assertNotContains('report-to default', $directives); | ||
| } | ||
|
|
||
| public function testClearNoncePlaceholdersWithDefaultTags(): void |
Member
There was a problem hiding this comment.
Remove these tests down and replace with the ones you have in ResponseTest but tailor it to be like in the majority of the tests here.
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
patel-vansh
force-pushed
the
fix/hardcoded-csp-tags
branch
from
97b1297 to
65b1a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #9935.
Created one method in
system/HTTP/ContentSecurityPolicy.phpto clear all nonce placeholders.Checklist: