fix: support Playwright 1.58+ output format in codeceptjs info (4.x)
#5437
+113
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright 1.58 changed the output format of `npx playwright install --dry-run`: - Old format: "browser: chromium version 143.0.7499.4" - New format: "Chrome for Testing 145.0.7632.6 (playwright chromium v1208)" Updated the regex to handle both formats while excluding chromium-headless-shell. Fixes codeceptjs#5422 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extract parsePlaywrightBrowsers function and add unit tests to verify both old (Playwright < 1.58) and new (1.58+) output formats are parsed correctly, and that chromium-headless-shell is excluded. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
codeceptjs info#5423 to the4.xbranch (as requested in fix: support Playwright 1.58+ output format incodeceptjs info#5423 (comment))module.exportsto ESMexportsyntax to match the 4.x codebaserequireto ESMimportTest plan
parsePlaywrightBrowserspass (npx mocha test/unit/command/info_test.js)