Open
Conversation
nicosammito
requested changes
Mar 28, 2026
Contributor
nicosammito
left a comment
nicosammito
left a comment
There was a problem hiding this comment.
And why not defining the type inside the definition file? This would increase readability and understanding
actions/gls-action/src/definitions/configDefinition/clientId.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/clientId.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/clientSecret.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/clientSecret.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/contactId.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/contactId.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/shipItApiUrl.ts
Outdated
Show resolved
Hide resolved
actions/gls-action/src/definitions/configDefinition/shipItApiUrl.ts
Outdated
Show resolved
Hide resolved
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/centaurus/-/pipelines/2415718244 Status: Passed |
Co-authored-by: Nico Sammito <nsammito@code0.tech> Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
nicosammito
requested changes
Mar 29, 2026
Contributor
nicosammito
left a comment
nicosammito
left a comment
There was a problem hiding this comment.
- tests should be moved outside of source and should be named test.
- Each test file should also have the suffix test.ts
- You have a lot of duplicated code like register... Why not just exporting the definition directly?
- You have some test files inside the functions directory
- Better folder structure for so many files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4