Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4285 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 896 896
Lines 26298 26306 +8
Branches 9496 9501 +5
=======================================
+ Hits 25623 25631 +8
- Misses 632 669 +37
+ Partials 43 6 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
54dfaf5 to
2c2fcfc
Compare
triggerRef prop and observer layout shiftstriggerRef prop to dropdown
mxschll
commented
Feb 26, 2026
| export const calculatePosition = ( | ||
| dropdownElement: HTMLDivElement, | ||
| triggerElement: HTMLDivElement, | ||
| triggerElement: HTMLElement, |
Member
Author
There was a problem hiding this comment.
Trigger can be any HTML element
mxschll
commented
Feb 26, 2026
| */ | ||
| trigger: React.ReactNode; | ||
|
|
||
| /** |
Member
Author
There was a problem hiding this comment.
Might update this comment after API proposal for trigger ref.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new
triggerRefprop to the Dropdown.Related links, issue #, if available: n/a
How has this been tested?
Pipeline is green.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.