Skip to content

feat: add triggerRef prop to dropdown#4285

Open
mxschll wants to merge 2 commits intomainfrom
dev-v3-schomax-dropdown-trigger-ref
Open

feat: add triggerRef prop to dropdown#4285
mxschll wants to merge 2 commits intomainfrom
dev-v3-schomax-dropdown-trigger-ref

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Feb 23, 2026

Description

Introduces a new triggerRef prop to the Dropdown.

Related links, issue #, if available: n/a

How has this been tested?

Pipeline is green.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (80272d6) to head (13225a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4285   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         896      896           
  Lines       26298    26306    +8     
  Branches     9496     9501    +5     
=======================================
+ Hits        25623    25631    +8     
- Misses        632      669   +37     
+ Partials       43        6   -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll force-pushed the dev-v3-schomax-dropdown-trigger-ref branch from 54dfaf5 to 2c2fcfc Compare February 26, 2026 19:53
@mxschll mxschll requested a review from ernst-dev February 26, 2026 20:32
@mxschll mxschll changed the title feat: add triggerRef prop and observer layout shifts feat: add triggerRef prop to dropdown Feb 26, 2026
export const calculatePosition = (
dropdownElement: HTMLDivElement,
triggerElement: HTMLDivElement,
triggerElement: HTMLElement,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trigger can be any HTML element

*/
trigger: React.ReactNode;

/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might update this comment after API proposal for trigger ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant