Fix: update specs to match err string w/o case sensitivity#717
Merged
Fix: update specs to match err string w/o case sensitivity#717
Conversation
Recent linting changes to bosh-utils have change the case of some err messages, this commit changes err message matching to be case-insensitive to avoid future breakage.
aramprice
requested review from
a team,
a-hassanin and
neddp
and removed request for
a team
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
selzoc
approved these changes
Mar 23, 2026
Member
selzoc
left a comment
selzoc
left a comment
There was a problem hiding this comment.
Technically they should always remain lowercase per go's error preferences, but I don't see too much harm in making the comparison case-insensitive.
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
KauzClay
approved these changes
Mar 23, 2026
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent linting changes to bosh-utils have change the case of some err messages, this commit changes err message matching to be case-insensitive to avoid future breakage.
See: cloudfoundry/bosh-utils@b5a3cf1
Fixes:
https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-cli/jobs/bump-deps/builds/133#L69b8d76a:198:203