Open
Conversation
mariash
force-pushed
the
add-dynamic-disks
branch
from
3d2c259 to
723ca3a
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
|
As discussed during the FI working group meeting, a change like this especially if it is gonna be used by something like diego needs an RFC. For more information about the RFC process please look here: https://github.com/cloudfoundry/community |
mariash
force-pushed
the
add-dynamic-disks
branch
from
723ca3a to
ca75226
Compare
aramprice
requested review from
a team,
KauzClay and
benjaminguttmann-avtq
and removed request for
a team
aramprice
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
Member
|
Converting to draft until cloudfoundry/community#1401 is accepted |
Member
Author
|
Marking as "Ready for review" since RFC is in FCP. |
It will resolve disk path based on hint and create symlink in data directory
It will delete the symlink to real device path in /var/vcap/data/dynamic_disks
mariash
force-pushed
the
add-dynamic-disks
branch
from
ca75226 to
2f17cf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces agent-side handling for attach and detach lifecycle operations for dynamically provisioned disks. It adds 2 agent actions:
add_dynamic_disk- resolves dynamic disk path for provided disk hint and creates a symlink/var/vcap/data/dynamic_disks/<diskID>remove_dynamic_disk- removes the symlink/var/vcap/data/dynamic_disks/<diskID>Please refer to the corresponding Director PR - cloudfoundry/bosh#2652