-
Notifications
You must be signed in to change notification settings - Fork 436
feat(ui): Introduce ceramic theme #7750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6ed7340 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughThis pull request introduces a new ceramic UI component system within the packages/ui directory. It establishes a comprehensive theme definition including color palettes, typography tokens, spacing, and utilities. A variants utility module provides CSS-in-JS styling composition with support for base styles, variant rules, defaults, and compound variants. The infrastructure includes a React theme provider component and hook for context consumption. Button and text styling modules demonstrate usage of the variants system. A changeset file documents the changes, and extensive unit and type tests validate the variants system functionality and type safety. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/ui/src/mosaic/index.ts`:
- Around line 1-4: Remove the barrel re-exports in this file and stop
re-exporting variants, buttonStyles, MosaicThemeProvider, useMosaicTheme,
mosaicTheme, and type MosaicTheme from a single index.ts; instead delete this
barrel and update consumers to import directly from the concrete modules (e.g.,
import { variants } from './mosaic/variants', import { buttonStyles } from
'./mosaic/button', import { MosaicThemeProvider, useMosaicTheme } from
'./mosaic/theme-provider', import { mosaicTheme, type MosaicTheme } from
'./mosaic/theme'). Ensure any package export maps or module entrypoints
reference the specific files rather than this index to avoid circular dependency
issues.
| --- | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty as there are no public changes in the PR
Description
Introduces the infra for Ceramic theme usage within c1 only components which should be unaffected by the appearance prop usage. This currently includes
<KeylessPrompt />and<EnableOrganizationsPrompt />.theme.tscontains theme tokens pulled from the ceramic design system found in dashboardvariants.tscontains a cva-like util for defining component variants as seem inbutton.tsandtext.ts.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Release Notes
New Features