Skip to content

fix: Set proper placeholder texts for system messages#7953

Merged
j-g00da merged 1 commit intomainfrom
j-g00da/fix-group-system-message-placeholdertexts
Mar 5, 2026
Merged

fix: Set proper placeholder texts for system messages#7953
j-g00da merged 1 commit intomainfrom
j-g00da/fix-group-system-message-placeholdertexts

Conversation

@j-g00da
Copy link
Contributor

@j-g00da j-g00da commented Mar 5, 2026

Don't use first-person form in placeholder texts,
as these can be misleading when broadcasted to group.
Additionally ensures that broadcasted system messages
are not localized to not leak locally-set language
to the group chat.

Fixes #7930

@j-g00da j-g00da requested a review from Hocuri March 5, 2026 12:02
@j-g00da j-g00da force-pushed the j-g00da/fix-group-system-message-placeholdertexts branch from 0c96801 to 7f57cf5 Compare March 5, 2026 13:52
@j-g00da j-g00da requested a review from link2xt March 5, 2026 13:54
@j-g00da j-g00da force-pushed the j-g00da/fix-group-system-message-placeholdertexts branch 2 times, most recently from 2024e6f to 7663e43 Compare March 5, 2026 14:36
Don't use first-person form in placeholder texts,
as these can be misleading when broadcasted to group.
Additionally ensures that broadcasted system messages
are not localized to not leak locally-set language
to the group chat.

Fixes #7930

Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
@j-g00da j-g00da force-pushed the j-g00da/fix-group-system-message-placeholdertexts branch from 7663e43 to ac6c475 Compare March 5, 2026 14:37
Copy link
Contributor

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing!

@j-g00da j-g00da enabled auto-merge (squash) March 5, 2026 14:54
@j-g00da j-g00da merged commit abb93cd into main Mar 5, 2026
55 of 56 checks passed
@j-g00da j-g00da deleted the j-g00da/fix-group-system-message-placeholdertexts branch March 5, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback messages for group modifications use the wrong string

3 participants