Skip to content

fix: validate config keys against known set in config set#12

Open
P-r-e-m-i-u-m wants to merge 1 commit intochainstacklabs:mainfrom
P-r-e-m-i-u-m:fix/validate-config-keys
Open

fix: validate config keys against known set in config set#12
P-r-e-m-i-u-m wants to merge 1 commit intochainstacklabs:mainfrom
P-r-e-m-i-u-m:fix/validate-config-keys

Conversation

@P-r-e-m-i-u-m
Copy link

Closes #6

Added validation in config_set() to reject unknown config keys before saving.

Changes

src/pumpfun_cli/commands/config.py

  • Added KNOWN_KEYS = {"rpc", "keyfile", "priority_fee", "compute_units"}
  • Added key validation in config_set() — rejects unknown keys with a clear error and hint showing valid keys

tests/test_commands/test_config_cmd.py

  • Added test_config_set_unknown_key — asserts that typos like rpcc are rejected with exit code != 0 and error message containing "unknown config key" and "valid keys"

Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>
@P-r-e-m-i-u-m P-r-e-m-i-u-m requested a review from smypmsa as a code owner March 18, 2026 10:13
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Warning

Rate limit exceeded

@P-r-e-m-i-u-m has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 89d077ec-c1be-4e5b-ba0f-468dd19c1353

📥 Commits

Reviewing files that changed from the base of the PR and between f813aed and 819aa2c.

📒 Files selected for processing (2)
  • src/pumpfun_cli/commands/config.py
  • tests/test_commands/test_config_cmd.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate config keys against known set in config set

1 participant