fix: validate config keys against known set in config set#12
fix: validate config keys against known set in config set#12P-r-e-m-i-u-m wants to merge 1 commit intochainstacklabs:mainfrom
Conversation
Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #6
Added validation in
config_set()to reject unknown config keys before saving.Changes
src/pumpfun_cli/commands/config.pyKNOWN_KEYS = {"rpc", "keyfile", "priority_fee", "compute_units"}config_set()— rejects unknown keys with a clear error and hint showing valid keystests/test_commands/test_config_cmd.pytest_config_set_unknown_key— asserts that typos likerpccare rejected with exit code != 0 and error message containing "unknown config key" and "valid keys"