Skip to content

Update release.yaml#764

Merged
alvarof2 merged 1 commit intomasterfrom
develop-npm-publishing-oidc
Mar 12, 2026
Merged

Update release.yaml#764
alvarof2 merged 1 commit intomasterfrom
develop-npm-publishing-oidc

Conversation

@alvarof2
Copy link
Member

@alvarof2 alvarof2 commented Mar 11, 2026

Use develop-npm-publishing-oidc for NPM packages.

PR is draft, will set as ready for review when this is configured in NPM registry for all packages


PR-Codex overview

This PR updates the GitHub Actions workflow configuration for releasing by modifying the uses directive to point to a different version of the npm-publish.yaml file, which likely includes changes related to OIDC (OpenID Connect) for token management.

Detailed summary

  • Changed uses from celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop
    to celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop-npm-publishing-oidc
  • Retained id-token: write and repository-projects: write permissions
  • Kept node-version: 20 and version-command: yarn version-then-update-files settings

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@alvarof2 alvarof2 requested a review from a team as a code owner March 11, 2026 13:16
@alvarof2 alvarof2 marked this pull request as draft March 11, 2026 13:16
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

size-limit report 📦

Path Size
import * from '@celo/core' (csj) 1.81 KB (0%)
import * from '@celo/core' (esm) 1.56 KB (0%)

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.61%. Comparing base (a695c5c) to head (3529577).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   69.61%   69.61%           
=======================================
  Files         150      150           
  Lines        7075     7075           
  Branches     1144     1153    +9     
=======================================
  Hits         4925     4925           
+ Misses       2085     2051   -34     
- Partials       65       99   +34     
Components Coverage Δ
celocli ∅ <ø> (∅)
sdk 69.12% <ø> (ø)
wallets 73.14% <ø> (ø)
viem-sdks 94.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alvarof2 alvarof2 marked this pull request as ready for review March 11, 2026 15:01
@alvarof2
Copy link
Member Author

alvarof2 commented Mar 11, 2026

Packages with OIDC enabled:

"name": "@celo/core"
"name": "@celo/typescript"
"name": "@celo/celocli"
"name": "@celo/explorer"
"name": "@celo/transactions-uri"
"name": "@celo/utils"
"name": "@celo/metadata-claims"
"name": "@celo/keystores"
"name": "@celo/phone-utils"
"name": "@celo/cryptographic-utils"
"name": "@celo/governance"
"name": "@celo/wallet-hsm-azure"
"name": "@celo/wallet-base"
"name": "@celo/wallet-ledger"
"name": "@celo/wallet-local"
"name": "@celo/wallet-hsm-aws"
"name": "@celo/wallet-hsm-gcp"
"name": "@celo/wallet-remote"
"name": "@celo/wallet-hsm"
"name": "@celo/contractkit"
"name": "@celo/connect"
"name": "@celo/base"
"name": "@celo/celo-devchain"
"name": "@celo/dev-utils"
"name": "@celo/actions"
"name": "@celo/viem-account-ledger"

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3529577720

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

id-token: write
repository-projects: write
uses: celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop
uses: celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop-npm-publishing-oidc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin reusable workflow to a stable ref

Switching the release job to @develop-npm-publishing-oidc makes production releases depend on a feature branch in another repository; if that branch is renamed, deleted, or force-pushed, pushes to master/hotfixes will fail to start the publish workflow and block package releases. Please reference an immutable tag or commit SHA instead of this temporary branch name.

Useful? React with 👍 / 👎.

@alvarof2 alvarof2 merged commit 2276386 into master Mar 12, 2026
40 of 53 checks passed
@alvarof2 alvarof2 deleted the develop-npm-publishing-oidc branch March 12, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants