Open
Conversation
lukman134
requested review from
dzakitajudin,
jacky-htg,
vdennis and
wahablie
jacky-htg
requested changes
Dec 4, 2020
Contributor
jacky-htg
left a comment
jacky-htg
left a comment
There was a problem hiding this comment.
please resolve my comments below. thanks.
) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table
* [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>
* add validation logic on login * [#9] add documentation * [#9] add documentation forgot password * [#9] revise add documentation forgot password * [#9] revise add document forgot password(2) * [#9] add forgot password layer image * [#9] revise forgot password layer and add documentation change password * [#9] add documentation reset password * add validation logic on login * [#9] revise documentation change password and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] update change password and reset password documentation * add validation logic on login * add validation logic on login * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] re-update change password, forgot password, and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] revise documentation change password * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] resolve conflict * [#9] update doc * [#9] update doc 2 Co-authored-by: Rijal Asepnugroho <rasepnugroho@waresix.com> Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>
* add validation logic on login * [#9] add documentation * [#9] add documentation forgot password * [#9] revise add documentation forgot password * [#9] revise add document forgot password(2) * [#9] add forgot password layer image * [#9] revise forgot password layer and add documentation change password * [#9] add documentation reset password * add validation logic on login * [#9] revise documentation change password and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] update change password and reset password documentation * add validation logic on login * add validation logic on login * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] re-update change password, forgot password, and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] revise documentation change password * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] resolve conflict * [#9] update doc * [#9] update doc 2 * [#2] Update documentation Employee (#15) * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> * [#9] add documentation * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] bring back acl-layer Co-authored-by: Rijal Asepnugroho <rasepnugroho@waresix.com> Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> Co-authored-by: ferrystiawan <56244036+ferrystiawan@users.noreply.github.com>
* [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#3] Delete company_code * [#3] Delete negative case at edit
* [#4] update branches api documentation * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#4] update branches api documentation * [#4] update endpoint and field branches api * [#4] update branches api documentation * [#4] update param query and positive case * [#4] add query param description with table Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>
jacky-htg
requested changes
Dec 15, 2020
jacky-htg
requested changes
Dec 16, 2020
Contributor
jacky-htg
left a comment
jacky-htg
left a comment
There was a problem hiding this comment.
please resolve my comments. thanks
jacky-htg
requested changes
Dec 18, 2020
Contributor
jacky-htg
left a comment
jacky-htg
left a comment
There was a problem hiding this comment.
you still not resolve my comment @lukman134
please resolve my comment before you ask my review.
thanks.
jacky-htg
requested changes
Dec 18, 2020
doc/groups.md
Outdated
| ### Response Payloads | ||
| HTTP Code | Status | Description | ||
| --- | --- | --- | ||
| 400 | Bad Request | Bad request payload |
Contributor
There was a problem hiding this comment.
please remove 400 response on GET /groups
doc/groups.md
Outdated
| 200 | OK | OK | ||
| ``` | ||
| { | ||
| "status_code": "CDC-400", |
Contributor
There was a problem hiding this comment.
there is no bad request on GET /groups
please change with 500 internal server error for example of error response
doc/groups.md
Outdated
| ``` | ||
| { | ||
| "status_code": "CDC-400", | ||
| "status_message": "Bad Request", |
Contributor
There was a problem hiding this comment.
there is no bad request on GET /groups
please change with 500 internal server error for example of error response
jacky-htg
requested changes
Dec 21, 2020
jacky-htg
approved these changes
Dec 22, 2020
dzakitajudin
approved these changes
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Progress on Groups API Doc :