feat(filter-ui): Add filters bar, help modal, and better tooltips#156
Open
maddada wants to merge 3 commits intocardisoft:masterfrom
Open
feat(filter-ui): Add filters bar, help modal, and better tooltips#156maddada wants to merge 3 commits intocardisoft:masterfrom
maddada wants to merge 3 commits intocardisoft:masterfrom
Conversation
…ction definitions and updating test descriptions
Author
|
@ldm0 Also implemented this feature because I need it, checked the code and it all looks good to me. I modified some of the styling by hand to make it better. Used Codex 5.4 high for the implementation but created a full plan before implementing and I believe the UX is perfect now. Please let me know what you think. It closes 2 issues (#44 and #113). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
This is another separate feature PR which adds the following filters bar to the app.
Closes #44 and #113
Full user facing requirements (generated by Codex 5.4 high based on the plan I worked on with it):
The files-tab search area now has a Filters toggle button on the right side of the main search bar. Clicking it or hides a secondary filter bar below the search input without changing the current query.
The filter bar appears only on the files tab.
The filter bar is visually grouped with separators between filter categories.
The filter controls are:
The In Folder, Parent Folder, and No Subfolders controls open a folder picker and insert the selected folder
into the query using the corresponding search filter syntax.
The non-path filters use dropdowns where that interaction makes sense.
The Regex Example control appends a fixed example regex filter to the query.
The toolbar edits the existing search query directly rather than maintaining a separate filter state.
Filter behavior is query-aware:
The filter controls were normalized visually:
The Info button is part of the filter bar, not the search input row, and is always right-aligned at the end of the last wrapped row.
Search Help Modal