fix: nil dereference in archive priority processing#269
Open
lczyk wants to merge 9 commits intocanonical:mainfrom
Open
fix: nil dereference in archive priority processing#269lczyk wants to merge 9 commits intocanonical:mainfrom
lczyk wants to merge 9 commits intocanonical:mainfrom
Conversation
Contributor
Author
|
sorry for the empty commit noise. the github workers were loosing their minds and i needed to retrigger a couple of times |
|
Contributor
Author
upils
suggested changes
Mar 6, 2026
internal/setup/setup_test.go
Outdated
| }, | ||
| relerror: `chisel.yaml: cannot parse maintenance: expected format for "standard" is YYYY-MM-DD`, | ||
| }, { | ||
| summary: "Maintenance: invalid pro in v2-archives ignored", |
Collaborator
There was a problem hiding this comment.
I believe this test is not tied to the "maintenance" feature. Unless I am missing something, it looks like the name (and the content of the chisel.yaml are making it difficult to actually know what is tested.
Also, to be inline with the last thing discussed in #267, I suppose a single test for V3 would be enough since the tested behavior is common for all formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
very niche, but the test by itself leads to a panic since we collect keys from
yamlArchivesbut then indexrelease.Archiveswith them