Skip to content

fix: duplicate slice test + message#268

Open
lczyk wants to merge 1 commit intocanonical:mainfrom
lczyk:duplicate-slice-message
Open

fix: duplicate slice test + message#268
lczyk wants to merge 1 commit intocanonical:mainfrom
lczyk:duplicate-slice-message

Conversation

@lczyk
Copy link
Contributor

@lczyk lczyk commented Mar 3, 2026

  • Have you signed the CLA?

  • remove needless \") from duplicate slices message
  • add stripBase to have only relative slice path in the message

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Command Mean [s] Min [s] Max [s] Relative
BASE 13.334 ± 0.066 13.228 13.448 1.00
HEAD 13.335 ± 0.090 13.219 13.538 1.00 ± 0.01

@lczyk lczyk requested a review from upils March 3, 2026 22:41
@lczyk lczyk added Simple Nice for a quick look on a minute or two Polish Refactorings, etc labels Mar 3, 2026
Copy link
Collaborator

@upils upils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Also thanks for adding the missing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Polish Refactorings, etc Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants