115 refactor per commonalities 577#117
Merged
caubut-charter merged 4 commits intocamaraproject:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
Based on comment from @hdamker from the source issue #115, I elected to do the following:
cd code/API_definitions
redocly bundle network-access-management.yaml --output network-access-management-bundled.yaml
redocly lint network-access-management.yaml
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #115
Does this PR introduce a breaking change?
Special notes for reviewers:
This is a structural refactor only -- no schema content was changed and no API behavior is affected. The bundled output (
network-access-management.yaml) is byte-for-byte identical before and after.What changed:
Domain/directory renamed tomodules/Domain/CAMARA_common.yamlmoved tocommon/CAMARA_common.yaml(separated from NAM-specific schemas)Templates/directory eliminated;network-access-management-template.yamlmoved to the root ofAPI_definitions/$refpaths updated across 4 files to reflect new locationsREADME.mdupdated to document the new layoutFiles with
$refpath changes (no content changes):network-access-management-template.yaml../Domain/...tomodules/...orcommon/...modules/NetworkAccessDevices/NetworkAccessDevices.yaml../CAMARA_common.yamlto../../common/CAMARA_common.yamlmodules/Services/ServiceSites.yaml../CAMARA_common.yamlto../../common/CAMARA_common.yamlVerification:
redocly bundleproduces identical output to pre-refactorredocly lintpasses with zero errorsDomain/orTemplates/references remain in any YAML fileChangelog input
Additional documentation
This section can be blank.