Conversation
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
grossyoan
left a comment
There was a problem hiding this comment.
Hi there!
Some small typos/additions on the first pages ready to review. It's a great piece of work 🙏
src/_guides/arazzo/specification/v1.0/introduction/what-is-arazzo.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/introduction/what-is-arazzo.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/components-and-references.md
Outdated
Show resolved
Hide resolved
…zzo.md Co-authored-by: Yoan Gross <32864409+grossyoan@users.noreply.github.com>
…zzo.md Co-authored-by: Yoan Gross <32864409+grossyoan@users.noreply.github.com>
grossyoan
left a comment
There was a problem hiding this comment.
Thanks a lot for the hard work, Phil 🙏
src/_guides/arazzo/specification/v1.0/understanding-structure/defining-sources.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/workflows.md
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/workflows.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/workflows.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/steps-inputs-outputs.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/success-and-failure.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/success-and-failure.md
Outdated
Show resolved
Hide resolved
| ## Component Types | ||
|
|
||
| Arazzo supports several component types, each designed to reduce repetition and make workflows easier to maintain. | ||
|
|
There was a problem hiding this comment.
We might want to add an "Inputs" title here with a few sentences to have it in the table of contents on the right.
There was a problem hiding this comment.
I find your comment completely accurate @grossyoan ler"'s add that subtitle?
src/_guides/arazzo/specification/v1.0/understanding-structure/components-and-references.md
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/working-with-arazzo/runtime-expressions.md
Show resolved
Hide resolved
complete guide from the guide page
Polo2
left a comment
There was a problem hiding this comment.
The whole reading is very interesting, we learn a lot about Arazzo specification and use case, with a lot of clear examples and the cheatsheet, well done 👏
I left two suggestions in code example to stick with the specification:
- clarification with string interpolation and runtime expression (based on sentence "Runtime expressions preserve the type of the referenced value. Expressions can be embedded into string values by surrounding the expression with {} curly braces.")
- clarification about how component is referenced (favor the full path with
$components.)
Beside that, all good to merge, and well done for the huge work 🙌
src/_guides/arazzo/specification/v1.0/understanding-structure/components-and-references.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/components-and-references.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/basic-structure.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/components-and-references.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/components-and-references.md
Outdated
Show resolved
Hide resolved
src/_guides/arazzo/specification/v1.0/understanding-structure/defining-sources.md
Outdated
Show resolved
Hide resolved
…components-and-references.md Co-authored-by: Polo <32060402+Polo2@users.noreply.github.com>
…components-and-references.md Co-authored-by: Polo <32060402+Polo2@users.noreply.github.com>
…basic-structure.md Co-authored-by: Polo <32060402+Polo2@users.noreply.github.com>
…components-and-references.md Co-authored-by: Polo <32060402+Polo2@users.noreply.github.com>
…defining-sources.md Co-authored-by: Polo <32060402+Polo2@users.noreply.github.com>
…components-and-references.md Co-authored-by: Polo <32060402+Polo2@users.noreply.github.com>
|
|
||
| Here the `authHeader` parameter is reused as-is, while `query` and `limit` are defined inline for this one step. | ||
|
|
||
| ## Referencing inputs |
There was a problem hiding this comment.
| ## Referencing inputs | |
| ### Referencing inputs |
|
|
||
| Each input schema can define properties, and use `$ref` to pull in reusable input components mixed in with inline definitions for just that workflow. | ||
|
|
||
| ## Referencing actions |
There was a problem hiding this comment.
| ## Referencing actions | |
| ### Referencing actions |
|
|
||
| Actions are where `reference` really shines: define consistent behavior once, then attach it to any step using `onSuccess` or `onFailure`. | ||
|
|
||
| ### Success actions |
There was a problem hiding this comment.
| ### Success actions | |
| #### Success actions |
|
|
||
| Because each success action has criteria, you can attach both and let runtime data decide whether the workflow continues (`goto`) or completes (`end`). | ||
|
|
||
| ### Failure actions |
|
|
||
| This step reuses the failure actions from earlier: retry on transient server errors, retry more cautiously when rate limited, and then route to a logging step if it still fails. | ||
|
|
||
| ### Conditional action reuse |
There was a problem hiding this comment.
| ### Conditional action reuse | |
| #### Conditional action reuse |
| ## Component Types | ||
|
|
||
| Arazzo supports several component types, each designed to reduce repetition and make workflows easier to maintain. | ||
|
|
There was a problem hiding this comment.
I find your comment completely accurate @grossyoan ler"'s add that subtitle?
| ## Component types | ||
|
|
||
| Arazzo supports several component types, each designed to reduce repetition and make workflows easier to maintain. | ||
|
|
| payload: | ||
| tripId: $steps.search.outputs.tripId | ||
| passengers: | ||
| - name: $inputs.passengers[0].name |
There was a problem hiding this comment.
It's quite unclear for me how runtine expressions when you need to access data within a payload (a payload being an object that is not described by the spec but by the API response or request bodies, parameters or inputs).
From what I understand from the spec it seems this line should be written:
| - name: $inputs.passengers[0].name | |
| - name: $inputs.passengers#/0/name |
However, I pretty much dislike and disagree with this syntax and Im much more aligned to what you wrote.. Internally at Bump we have defined a custom spec which will allow to use jmespath (or maybe jsonpath) in those expressions so that dot notations work as we could expect.
What do you think? Is this something I misunderstood?
|
|
||
| ```yaml | ||
| inputs: | ||
| type: object |
There was a problem hiding this comment.
This doesnt look like an array input (as stated by the title). Can you change the example please?
| outputs: | ||
| # Extract simple values | ||
| bookingId: $response.body.id | ||
| customerEmail: $response.body.customer.email |
There was a problem hiding this comment.
As stated in a previous comment, Im completely aligned with your dot notation to access payload data. But I dont think it's how arazzo specifies it (even if it isnt really clear)...
The Arazzo Specification Guide is taking form.
Introduction
Understanding Structure
Working with Arazzo
Misc