Fix macOS app PID selection to avoid helper processes#28
Open
gambit36 wants to merge 1 commit intobrowser-use:mainfrom
Open
Fix macOS app PID selection to avoid helper processes#28gambit36 wants to merge 1 commit intobrowser-use:mainfrom
gambit36 wants to merge 1 commit intobrowser-use:mainfrom
Conversation
|
|
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="mlx_use/controller/service.py">
<violation number="1" location="mlx_use/controller/service.py:52">
P2: When scored selection returns `None`, fallback `pgrep` picks the first matching PID without helper/background filtering, reintroducing wrong app PID selection.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| return None | ||
| scored.sort(key=lambda item: item[0], reverse=True) | ||
| best_score, best_app = scored[0] | ||
| return best_app if best_score > 0 else None |
There was a problem hiding this comment.
P2: When scored selection returns None, fallback pgrep picks the first matching PID without helper/background filtering, reintroducing wrong app PID selection.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At mlx_use/controller/service.py, line 52:
<comment>When scored selection returns `None`, fallback `pgrep` picks the first matching PID without helper/background filtering, reintroducing wrong app PID selection.</comment>
<file context>
@@ -7,6 +7,50 @@
+ return None
+ scored.sort(key=lambda item: item[0], reverse=True)
+ best_score, best_app = scored[0]
+ return best_app if best_score > 0 else None
+
from mlx_use.agent.views import ActionModel, ActionResult
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When opening Safari, the previous bundle-id substring match could resolve to
com.apple.SafariPlatformSupport.Helperinstead of the main Safari app. That caused UI tree reads to miss the real window content.Validation
print_app_tree.pyresolves the main Safari app and returns interactive elements from the real windowSummary by cubic
Fixes macOS PID resolution to pick the main foreground app instead of helper/background processes, so UI tree reads target the actual window (e.g., Safari’s main process, not PlatformSupport.Helper).
print_app_tree.pyexample.Written for commit 16d710a. Summary will update on new commits.