Conversation
This commit adds Push methods to all of the sio writers so that they now implement vio.Pusher. This provides an obvious "to do" list for which writers should implement direct vector endcoding (e.g., parquet). It should also be pretty clear now how to change over the service handler to emit CSUP instead of BSUP. This now means that the CSUP writer is wired directly to the vam output and vectors are encoded directly for CSPU without a trip through scode. Also, the query paths for super -c and super db -c are now wrapped with context checks (vio.CopyMuxWithContext). While the underlying read calls should get canceled with ctrl-c, this adds a bit of fullproofing for code paths that miss this so I think it's a good addition for now. But we can take it out if we think it's not necessary; or maybe take it out, after more comprehensive testing?
nwt
reviewed
Mar 15, 2026
nwt
reviewed
Mar 15, 2026
nwt
approved these changes
Mar 15, 2026
| @@ -1,3 +1,5 @@ | |||
| skip: this test splits hairs and not important for now... the pusher interface changed this all | |||
Member
There was a problem hiding this comment.
Remove if you don't want to resurrect later.
Collaborator
Author
There was a problem hiding this comment.
This feature is still there. Just need to update the test at some point.
Collaborator
Author
There was a problem hiding this comment.
...with something less fussy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds Push methods to all of the sio writers so that they now implement vio.Pusher. This provides an obvious "to do" list for which writers should implement direct vector endcoding (e.g., parquet).
It should also be pretty clear now how to change over the service handler to emit CSUP instead of BSUP.
This now means that the CSUP writer is wired directly to the vam output and vectors are encoded directly for CSPU without a trip through scode.
Also, the query paths for super -c and super db -c are now wrapped with context checks (vio.CopyMuxWithContext). While the underlying read calls should get canceled with ctrl-c, this adds a bit of foolproofing for code paths that miss this so I think it's a good addition for now. But we can take it out if we think it's not necessary; or maybe take it out, after more comprehensive testing?