Conversation
This commit moves us another step closer to the vam-only runtime. These changes are purely package moves and renames. No code changes. We created package vio to mirror sbuf and moved the vector interfaces into this package. Also recast vector.Puller/Writer to Pusher/Puller as is idomatic in database engines. The idea here is that the sio writers will become serializers that impelment the vector.Push interface and write to io.Writer. Like now, they'll have close which means flush any partially serialized data to the writer. We also moved the vam materializer/dematerializer to sbuf to emphasize that it's the bridge to escape into and out of the scode world from the vector runtime.
nwt
approved these changes
Mar 14, 2026
sio/csupio/writer.go
Outdated
| // NewWriter returns a writer to w. | ||
| func NewWriter(w io.WriteCloser) *csup.Writer { | ||
| return csup.NewWriter(w) | ||
| // NewSerializer returns a new CSUP serialized that outputs to w. |
Member
There was a problem hiding this comment.
Suggested change
| // NewSerializer returns a new CSUP serialized that outputs to w. | |
| // NewSerializer returns a new CSUP serializer that outputs to w. |
vector/named.go
Outdated
Comment on lines
+29
to
+40
|
|
||
| type Labeled struct { | ||
| Any | ||
| Label string | ||
| } | ||
|
|
||
| func Unlabel(vec Any) (Any, string) { | ||
| if vec, ok := vec.(*Labeled); ok { | ||
| return vec.Any, vec.Label | ||
| } | ||
| return vec, "" | ||
| } |
Member
There was a problem hiding this comment.
I think this should go in vio too or, barring that, in a separate file since its unrelated to vector.Named.
sbuf/mux.go
Outdated
Comment on lines
+35
to
+58
| @@ -55,3 +55,4 @@ func CopyMux(outputs map[string]sio.WriteCloser, parent Puller) error { | |||
| batch.Unref() | |||
| } | |||
| } | |||
| */ | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves us another step closer to the vam-only runtime. These changes are purely package moves and renames. No code changes.
We created package vio to mirror sbuf and moved the vector interfaces into this package. Also recast vector.Puller/Writer to Pusher/Puller as is idomatic in database engines. The idea here is that the sio writers will become serializers that impelment the vector.Push interface and write to io.Writer. Like now, they'll have close which means flush any partially serialized data to the writer.
We also moved the vam materializer/dematerializer to sbuf to emphasize that it's the bridge to escape into and out of the scode world from the vector runtime.