Fix property ordering transforms for google payloads#189
Merged
Ken Jiang (knjiang) merged 1 commit intomainfrom Apr 10, 2026
Merged
Fix property ordering transforms for google payloads#189Ken Jiang (knjiang) merged 1 commit intomainfrom
Ken Jiang (knjiang) merged 1 commit intomainfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Ken Jiang (knjiang)
changed the title
aswink
reviewed
Apr 10, 2026
| fn normalize_for_target( | ||
| &mut self, | ||
| target_provider: ProviderFormat, | ||
| strip_google_only_fields: bool, |
Contributor
There was a problem hiding this comment.
why do we need this? can we use target_provider instead?
Contributor
Author
There was a problem hiding this comment.
ya i think we can just use target_provider.
Ken Jiang (knjiang)
force-pushed
the
04-10-fix_property_ordering
branch
from
60e0468 to
0ad030e
Compare
aswink
approved these changes
Apr 10, 2026
Ken Jiang (knjiang)
force-pushed
the
04-10-fix_property_ordering
branch
from
0ad030e to
63fd234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.