Add first-class WAL footer version and auto-derived storage URIs#76
Open
Alex Soldatchenko (soldatchenko) wants to merge 10 commits intomainfrom
Open
Add first-class WAL footer version and auto-derived storage URIs#76Alex Soldatchenko (soldatchenko) wants to merge 10 commits intomainfrom
Alex Soldatchenko (soldatchenko) wants to merge 10 commits intomainfrom
Conversation
Alex Soldatchenko (soldatchenko)
changed the title
Contributor
|
Can you change this PR description to tell users context and what, if anything, they need to do? I don't think any customer reading this will understand |
Mike Deeks (mdeeks)
requested changes
Apr 11, 2026
| BRAINSTORE_LOCKS_URI: "az://{{ .Values.objectStorage.azure.brainstoreContainer }}/brainstore/locks" | ||
| {{- end }} | ||
| {{- if .Values.objectStorage.azure.responseContainer }} | ||
| BRAINSTORE_RESPONSE_CACHE_URI: "az://{{ .Values.objectStorage.azure.responseContainer }}" |
Contributor
There was a problem hiding this comment.
I dont think this is right? There should be a path I think? Can you please double and triple check all of these? If we get them wrong it is essentially impossible to fix later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds chart support for the Data Plane 2.0 upgrade path.
brainstoreWalFooterVersionis now a first-class value,BRAINSTORE_RESPONSE_CACHE_URIandBRAINSTORE_CODE_BUNDLE_URIare auto-derived from existing objectStorage config on all Brainstore pods, andWAL_USE_EFFICIENT_FORMATis decoupled to fire on either WAL footer version orskipPg.brainstoreWalFooterVersionsetsBRAINSTORE_WAL_FOOTER_VERSIONon API podWAL_USE_EFFICIENT_FORMATfires when eitherbrainstoreWalFooterVersionorskipPgForBrainstoreObjectsis setRESPONSE_CACHE_URI/CODE_BUNDLE_URIauto-derived from objectStorage config (AWS, GCP, Azure) on reader/writer/fastreader