add support for pushing sandboxes#72
add support for pushing sandboxes#72Nathan Selvidge (nselvidge) wants to merge 3 commits intomainfrom
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Parker Henderson (parkerhendo)
force-pushed
the
functions-push-pull-command
branch
from
a6b375c to
5f7d51f
Compare
Nathan Selvidge (nselvidge)
force-pushed
the
nate/sandbox-push
branch
2 times, most recently
from
1ff2094 to
309441c
Compare
Nathan Selvidge (nselvidge)
changed the base branch from
functions-push-pull-command
to
main
Nathan Selvidge (nselvidge)
force-pushed
the
nate/sandbox-push
branch
from
309441c to
8de1749
Compare
Nathan Selvidge (nselvidge)
requested a review
from Parker Henderson (parkerhendo)
Parker Henderson (parkerhendo)
left a comment
Parker Henderson (parkerhendo)
left a comment
There was a problem hiding this comment.
Not blocking I don't think but one small note related to eval parameters
scripts/functions-runner.ts
Outdated
| const serialized = toJsonValue(rawParams as JsonValue); | ||
| if (serialized !== undefined) { | ||
| evaluatorDefinition.parameters = serialized; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we reuse the existing evaluator-parameter serialization flow from eval-runner.ts here, instead of the direct toJsonValue(rawParams) path? I think using the shared serializer covers some cases with Zod->JSON Schema conversion that help avoid malformed evaluator_definition.parameters for parameterized evals.
There was a problem hiding this comment.
I tried extracting this into a new file, but the eval-runner doesn't play nice with local exports since it needs to run with multiple runner types in a way the functions-runner doesn't. I'm going to just copy the logic over from eval-runner. I'm a bit hesitant to move to a complex local file structure for these runners since they need to work in so many situations, but let me know if you think that's the wrong approach
There was a problem hiding this comment.
I'm a bit hesitant to move to a complex local file structure for these runners since they need to work in so many situations, but let me know if you think that's the wrong approach
Nope, totally agree with this.
Nathan Selvidge (nselvidge)
force-pushed
the
nate/sandbox-push
branch
from
3be1c58 to
52e6f9c
Compare
Nathan Selvidge (nselvidge)
force-pushed
the
nate/sandbox-push
branch
3 times, most recently
from
92bb115 to
ba3ddf0
Compare
2 participants
Adds the ability to push sandboxes using the
bt function pushcommand. pushes lambda sandboxes for each language.