fix(adk): avoid duplicate sync runner invocation spans#252
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
fix(adk): avoid duplicate sync runner invocation spans#252Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
Trace only Runner.run_async because supported ADK versions route the sync Runner.run API through the async implementation. Patching both surfaces created duplicate invocation spans for sync callers. Add a regression test and cassette coverage to verify Runner.run emits a single invocation span with the expected child agent span structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace only Runner.run_async because supported ADK versions route the sync Runner.run API through the async implementation. Patching both surfaces created duplicate invocation spans for sync callers.
Add a regression test and cassette coverage to verify Runner.run emits a single invocation span with the expected child agent span structure.
fixes https://linear.app/braintrustdata/issue/BT-4720/adk-runnerrun-produces-duplicate-nested-invocation-spans