fix(integrations): unify multimodal attachment materialization#247
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits intomainfrom
Open
fix(integrations): unify multimodal attachment materialization#247Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-refactor-integration-attachment-utils
branch
from
25cd9b2 to
4f350b5
Compare
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-refactor-integration-attachment-utils
branch
from
be5b4c3 to
b103b41
Compare
Consolidate provider tracing onto a shared attachment materialization helper so image, file, and binary payloads are logged consistently across integrations. This also fixes non-image multimodal parts to use file payloads instead of image_url shims where appropriate. Preserve non-attachment values when materializing interaction payloads so provider-specific models, enums, and datetimes are not re-serialized during logging. Add focused regression coverage for the shared helper and affected providers.
Abhijeet Prasad (AbhiPrasad)
force-pushed
the
abhi-refactor-integration-attachment-utils
branch
from
b103b41 to
6991ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #245
We're doing more multimodal stuff in the SDK (sending things as attachments), so I want to clean this up + fix inconsistencies in how we are sending data.
Consolidate provider tracing onto a shared attachment materialization helper so image, file, and binary payloads are logged consistently across integrations. This also fixes non-image multimodal parts to use file payloads instead of image_url shims where appropriate.
Preserve non-attachment values when materializing interaction payloads so provider-specific models, enums, and datetimes are not re-serialized during logging. Add focused regression coverage for the shared helper and affected providers.