fix: Capture anthropic server tool use inputs for streaming APIs#1776
Merged
Luca Forstner (lforst) merged 14 commits intomainfrom Apr 13, 2026
Merged
fix: Capture anthropic server tool use inputs for streaming APIs#1776Luca Forstner (lforst) merged 14 commits intomainfrom
Luca Forstner (lforst) merged 14 commits intomainfrom
Conversation
Luca Forstner (lforst)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Stephen Belanger (Qard)
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 10, 2026
Comment on lines
+315
to
+329
| if (contentBlock.type === "tool_use") { | ||
| contentBlocks[index] = { | ||
| type: "tool_use", | ||
| id: contentBlock.id, | ||
| name: contentBlock.name, | ||
| input: parsedInput, | ||
| }; | ||
| } else { | ||
| contentBlocks[index] = { | ||
| type: "server_tool_use", | ||
| id: contentBlock.id, | ||
| name: contentBlock.name, | ||
| input: parsedInput, | ||
| }; | ||
| } |
There was a problem hiding this comment.
isToolUseLikeContentBlock narrows, we can just do
contentBlocks[index] = {
type: contentBlock.type,
id: contentBlock.id,
name: contentBlock.name,
input: parsedInput,
};| }) satisfies Json; | ||
| }); | ||
|
|
||
| if (options?.dropEmptyOutputTextMessages) { |
There was a problem hiding this comment.
why this change, related to a flake?
Member
Author
There was a problem hiding this comment.
it's just about normalization across versions
Member
Author
There was a problem hiding this comment.
adding a comment
…er-tools # Conflicts: # e2e/scenarios/openai-instrumentation/assertions.ts
…er-tools # Conflicts: # e2e/scenarios/anthropic-instrumentation/assertions.ts # e2e/scenarios/anthropic-instrumentation/scenario.anthropic-v0273.mjs # e2e/scenarios/anthropic-instrumentation/scenario.anthropic-v0273.ts # e2e/scenarios/anthropic-instrumentation/scenario.anthropic-v0390.mjs # e2e/scenarios/anthropic-instrumentation/scenario.anthropic-v0390.ts # e2e/scenarios/anthropic-instrumentation/scenario.impl.mjs # e2e/scenarios/anthropic-instrumentation/scenario.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1660