Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aswink
force-pushed
the
aswin/04-10-use_locations_instead_of_supported_regions
branch
from
4441e65 to
3ee820b
Compare
Comment on lines
-2927
to
-2929
| "supported_regions": [ | ||
| "global" | ||
| ], |
Contributor
There was a problem hiding this comment.
should we specify locations for specific models?
Contributor
Author
There was a problem hiding this comment.
after your comment on the other PR I realized that this wasn't vertex, this is google, which is why this was removed here
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4441e656c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
aswink
force-pushed
the
aswin/04-10-use_locations_instead_of_supported_regions
branch
from
3ee820b to
ae11cf3
Compare
Ken Jiang (knjiang)
approved these changes
Apr 10, 2026
aswink
force-pushed
the
aswin/04-10-use_locations_instead_of_supported_regions
branch
from
ae11cf3 to
a5473d3
Compare
aswink
force-pushed
the
aswin/04-10-use_locations_instead_of_supported_regions
branch
from
a5473d3 to
5458805
Compare
I just noticed that we already had a locations field, so revert the supported_regions change I made in favor of locations, and actually update those vertex models to have the correct locations. Also update them to add available_providers to ["vertex"].
aswink
force-pushed
the
aswin/04-10-use_locations_instead_of_supported_regions
branch
from
5458805 to
1e17594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that we already had a locations field, so revert the
supported_regions change I made in favor of locations, and actually update
those vertex models to have the correct locations. Also update them to add
available_providers to ["vertex"].