Add hickory support to ShuffleResolver#4
Open
Kevin Green (KevinGreen) wants to merge 4 commits intomanu/azure-handle-file-already-existsfrom
Open
Add hickory support to ShuffleResolver#4Kevin Green (KevinGreen) wants to merge 4 commits intomanu/azure-handle-file-already-existsfrom
Kevin Green (KevinGreen) wants to merge 4 commits intomanu/azure-handle-file-already-existsfrom
Conversation
Kevin Green (KevinGreen)
changed the title
Kevin Green (KevinGreen)
requested review from
Ankur Goyal (ankrgyl) and
Manu Goyal (manugoyal)
Ankur Goyal (ankrgyl)
approved these changes
Mar 19, 2026
Ankur Goyal (ankrgyl)
left a comment
Ankur Goyal (ankrgyl)
left a comment
There was a problem hiding this comment.
this could be worth upstreaming
|
I wonder if we'll want to coordinate this PR with #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Adds hickory dns support to ShuffleResolver, using the same approach as reqwest when the hickory-dns feature is enabled, but shuffling the names after resolving.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?