Adds escaping of some uncommon but valid email characters#3
Merged
a6software merged 1 commit intodevelopfrom Feb 8, 2019
Merged
Adds escaping of some uncommon but valid email characters#3a6software merged 1 commit intodevelopfrom
a6software merged 1 commit intodevelopfrom
Conversation
jmorgan74
reviewed
Feb 8, 2019
| if ( parent::remove_from_requests( $index ) ) { | ||
| $token = GDPR::generate_pin(); | ||
| GDPR_Email::send( $user->user_email, 'delete-resolved', array( 'token' => $token ) ); | ||
| GDPR_Email::send( $this->get_escaped_user_email_address( $user ), 'delete-resolved', array( 'token' => $token ) ); |
There was a problem hiding this comment.
Suggested change
| GDPR_Email::send( $this->get_escaped_user_email_address( $user ), 'delete-resolved', array( 'token' => $token ) ); | |
| $email_address = $this->get_escaped_user_email_address( $user ) | |
| GDPR_Email::send( $email_address , 'delete-resolved', array( 'token' => $token ) ); |
There was a problem hiding this comment.
I just prefer to avoid "train coach" code, feels more readable. Not really an issue though, just readability.
Author
There was a problem hiding this comment.
Aye, it's a good shout. TBH Jon I'm just trying to do the bare minimum with it to get it to a place where we can replace the existing GDPR plugin with this fork. I don't want to change anything too much, at this stage, just so if anything goes wrong there's less to rule out.
I will get onto tidying this entire thing up as part of a further PR I have in progress currently.
jenkoian
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds escaping of some uncommon but valid email characters
Copy of upstream PR - trewknowledge#236