fix: Normalize inquirer signal-exit compatibility on Windows#645
Open
arjankowski wants to merge 1 commit intomainfrom
Open
fix: Normalize inquirer signal-exit compatibility on Windows#645arjankowski wants to merge 1 commit intomainfrom
signal-exit compatibility on Windows#645arjankowski wants to merge 1 commit intomainfrom
Conversation
arjankowski
changed the title
signal-exit compatibility on Windows
Pull Request Test Coverage Report for Build 23065163996Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a Windows packaging issue where inquirer could crash with
signalExitis not a function duringoclif pack:winbecause restore-cursor may resolve to signal-exit@4 (object export) instead of the older function-style export.I've added a small compatibility shim in
src/inquirer.jsthat wraps object-style signal-exit into a callable function before loading inquirer, and we updatedtest/inquirer.test.jsto cover both behaviors (wrap object export, keep function export unchanged). I've also added signal-exit as an explicit dev dependency to keep test imports clear and lint-safe.This started appearing in
v4.5.0after dependency changes.