Added include_paths option to whitelist files & paths#217
Draft
niekdomi wants to merge 4 commits intoblopker:mainfrom
Draft
Added include_paths option to whitelist files & paths#217niekdomi wants to merge 4 commits intoblopker:mainfrom
include_paths option to whitelist files & paths#217niekdomi wants to merge 4 commits intoblopker:mainfrom
Conversation
include_paths option to white list files & pathsinclude_paths option to whitelist files & paths
Owner
|
Thanks for this. Can you describe in more detail how include_paths and ignore_paths should interact with each other? Maybe the config should be invalid if both are included? |
Contributor
Author
|
The idea is basically:
Let's say you only want They are complementary, though include_paths = [
"**/*.yaml",
]
ignore_paths = [
"**/*.yaml",
]would lint nothing. Should I add some test cases to "demonstrate" the expected behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option was quite convenient when developing a cli for codebook and i think its a nice addition to the
ignore_paths. E.g., if only.rsfiles should be linted, I think it's better to use theinclude_pathsrather than ignoring everything withignore_paths.