Merged
Conversation
Add VHDL as a supported language for spell checking using tree-sitter-vhdl grammar from jpt13653903/tree-sitter-vhdl (v1.3.1, git dependency). Changes: - Add tree-sitter-vhdl workspace and crate dependencies - Add VHDL variant to LanguageType enum with language setting - Create vhdl.scm query capturing comments, strings, identifiers (entity, architecture, signal, variable, constant, function, procedure, component, type, subtype, port, label, alias) - Add example.vhd with intentional spelling errors - Add test_vhdl.rs with simple and location verification tests - Add VHDL to supported languages table in README
niekdomi
reviewed
Feb 25, 2026
| "#; | ||
| let expected = vec
There was a problem hiding this comment.
imho clk is a quite common term for the clock and shouldn't be an error. It should perhaps be added to word_lists/
Owner
There was a problem hiding this comment.
Very true! If you add clk to one of the word lists I'd merge that too :) Generally any common technical terms that are unlikely to be misspellings I'm happy to add to the word lists.
Owner
|
This is awesome! Thank you! |
Owner
|
Hm, sadly this tree-sitter parser has a few thread safety issues and is causing flaky tests in Codebook. I've opened a PR in that repo, but can't actually put this out until that's fixed: jpt13653903/tree-sitter-vhdl#61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add VHDL as a supported language for spell checking using the tree-sitter-vhdl grammar (v1.3.1).
Changes
Cargo.tomltree-sitter-vhdlgit dependency (not on crates.io)crates/codebook/Cargo.tomlcrates/codebook/src/queries.rsVHDLenum variant, language setting, match armcrates/codebook/src/queries/vhdl.scmexamples/example.vhdcrates/codebook/tests/test_vhdl.rsREADME.mdQuery Captures
line_comment,block_comment(viacomment_content)string_literalinterface_declaration,interface_signal_declaration,interface_variable_declaration,interface_constant_declarationlabelTesting
cargo test -p codebook --lib— 32/32 pass (includingtest_all_queries_are_valid)cargo test -p codebook --test test_vhdl— 2/2 passmake test— full suite passes with 0 failures