feat: typed Command headers and default error codes#13
Merged
Conversation
ServiceError/ServiceResponseError default to UNAVAILABLE, PublicValibotHonoError defaults to INVALID_ARGUMENT. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add 4th generic CommandHeaders to Command with a public readonly headers property and optional constructor arg. RestServiceClient merges command.headers into the fetch request between client-level and runtime headers. Fully backward compatible — commands without headers are unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandHeaderstoCommandwithpublic readonly headersproperty and optional constructor argRestServiceClient.response()mergescommand.headersinto fetch request headers (client → command → runtime priority)ServiceError/ServiceResponseError→UNAVAILABLE,PublicValibotHonoError→INVALID_ARGUMENTTest plan
🤖 Generated with Claude Code