Skip to content

fix: log when background snapshot cache upload is skipped due to lock contention#171

Merged
worstell merged 1 commit intomainfrom
log-skipped-background-upload
Mar 11, 2026
Merged

fix: log when background snapshot cache upload is skipped due to lock contention#171
worstell merged 1 commit intomainfrom
log-skipped-background-upload

Conversation

@worstell
Copy link
Contributor

Adds an info log when the background cache upload goroutine in writeSnapshotSpool is skipped because the snapshot mutex is already held. Previously this was a silent return, making it impossible to diagnose why snapshots weren't being cached.

@worstell worstell requested a review from a team as a code owner March 11, 2026 00:56
@worstell worstell requested review from js-murph and removed request for a team March 11, 2026 00:56
@worstell worstell merged commit 595b390 into main Mar 11, 2026
6 checks passed
@worstell worstell deleted the log-skipped-background-upload branch March 11, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants