style(mark): redesign code review subtitle with badges and type-specific icons#370
Merged
style(mark): redesign code review subtitle with badges and type-specific icons#370
Conversation
…ic icons Show time first in the timeline, then comment counts as round-rect badges with icons instead of text. Annotations are only shown when there are no comments. Use comment-type-specific icons (warning, suggestion, issue, info) consistently across the timeline, diff sidepanel comment list, and file tree indicators. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Show comment and annotation counts as separate badges instead of either/or. Switch badges to outline style (border instead of fill), add more padding, and use align-items: center for proper vertical alignment with the time label. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…diff UI Show per-type badges (warning, suggestion, issue, comment, annotation) in the branch timeline instead of generic comment/annotation badges. Each badge uses the same icon and color as the diff sidepanel and file tree: AlertTriangle for warnings, Lightbulb for suggestions, CircleAlert for issues, MessageSquare for plain comments, and Info for annotations. Also fix CSS specificity bug in DiffFileTreeSection where the rule order (warning → suggestion → issue → info) didn't match the icon priority (issue > warning > suggestion > info), causing a color/icon mismatch when multiple comment types were present on the same file. Reorder rules so the highest-priority type's color wins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s all views Unify icons between the branch timeline badges and the diff UI to use only two types: MessageSquare for normal comments and AlertTriangle for warnings. Previously the diff UI used four different type-specific icons (warning, suggestion, issue, information) while the timeline only had generic comment/annotation badges. Now both places use the same two-icon system: - MessageSquare (comment) for all non-warning comments - AlertTriangle (warning) for warnings Remove unused icon imports (CircleAlert, Lightbulb, Info) and their associated CSS classes from DiffCommentsSection, DiffFileTreeSection, and TimelineRow.
Show both the agent icon (Bot) and the comment type icon in the diff sidebar comment list. Agent-authored comments display a Bot icon in --status-modified color followed by the type icon (AlertTriangle for warnings, MessageSquare otherwise). User-authored comments show only the type icon. Wrap both icons in a flex container (.comment-icons) and increase the comment item left padding to accommodate the extra icon width.
Use the same muted color and border for warning badges as regular comment badges in the branch timeline, instead of highlighting warnings in --status-modified color. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b90bf13b62
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| // Build badges: warnings get their own badge, everything else is a comment | ||
| const warningCount = breakdown?.warnings ?? 0; | ||
| const nonWarningCount = totalCount - warningCount; |
There was a problem hiding this comment.
nonWarningCount is derived from totalCount - warningCount, but totalCount includes annotationCount, so hold-to-reveal annotations are being counted as regular comments in the badge. In reviews that contain annotations, this inflates the comment badge (for example, 1 warning + 2 annotations shows a comment badge of 2 even though there are no non-warning visible comments), which makes the timeline counts misleading; this should be based on commentCount (non-annotation comments) rather than totalCount.
Useful? React with 👍 / 👎.
Use commentCount instead of totalCount when computing nonWarningCount so that hold-to-reveal annotations are not inflated into the comment badge on the branch timeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code