fix(mark): handle amended commits on resumed sessions and clean up stale reviews#369
fix(mark): handle amended commits on resumed sessions and clean up stale reviews#369
Conversation
…auto reviews When resuming a session linked to a commit, capture pre_head_sha so amended commits are detected and the commit record is updated with the new SHA. Also filter find_latest_auto_review to only return reviews created after the most recent commit, preventing stale auto reviews from surfacing after amendments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When deleting a commit (pending or landed), find all reviews on the branch created at or after the commit's timestamp and delete them. Active review sessions are cancelled via the registry before deletion, preventing stale auto reviews from resurfacing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This method became unused after get_commit_by_session replaced it in session_runner.rs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ffaff750c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| registry: &session_runner::SessionRegistry, | ||
| commit: &store::models::Commit, | ||
| ) { | ||
| let reviews = match store.find_reviews_created_since(&commit.branch_id, commit.created_at) { |
There was a problem hiding this comment.
cleanup_reviews_after_commit selects reviews only by branch_id and created_at >= commit.created_at, so deleting a pending commit (or deleting HEAD after later manual reviews were added) will also delete unrelated reviews and their sessions on the same branch. For example, a manual review created later for an older surviving commit is still removed because it matches the timestamp window, which causes user data loss beyond the commit being deleted.
Useful? React with 👍 / 👎.
Pending/failed commits without a SHA never produced a reviewable diff, so deleting them should not cascade-delete reviews on the branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
get_commit_by_session(not just pending commits)find_latest_auto_reviewonly returns reviews created after the most recent commit on the branchTest plan
🤖 Generated with Claude Code