Conversation
D33r-Gee
force-pushed
the
alt-qml-snapshotload
branch
3 times, most recently
from
26a2e0f to
5e561ef
Compare
|
I don't know why CI is able to build, I am failing locally which makes sense because but your commit is not part of that repo, so I get: I am still trying to figure out what the "file" protocol message is about but otherwise I sort of expected to see this error in CI as well. ChatGPT suspects that the github "checkout" action may have access to some huge github-wide cache and is somehow able to look up |
|
The fix for me locally which I think should be part of the PR is: diff --git a/.gitmodules b/.gitmodules
index fabdfe506..03c475675 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,3 @@
[submodule "bitcoin"]
path = bitcoin
- url = https://github.com/bitcoin/bitcoin
+ url = https://github.com/D33r-Gee/bitcoinThen I executed: This tells git to re-read
|
|
concept and tested ACK, no code review yet 
|
Thanks for testing @pinheadmz ! As you saw currently updating the upstream portion which will impact code review here. Ultimately, the snapshot processing (path → file & metadata) will be moved there. Once the flow is more solid in that location, I’ll update the code here accordingly by removing the models/snapshotqml files and updating the snapshot info retrieval method. |
D33r-Gee
force-pushed
the
alt-qml-snapshotload
branch
2 times, most recently
from
daf644c to
a05e12c
Compare
|
with a05e12c addresses @pinheadmz comment about pointing the submodule url to my repo daf644c squashed the snapshot loading functionality into one commit and has been updated with new interface from upstream (bitcoin/bitcoin PR#33117) |
|
Reviewing bitcoin/bitcoin#33117 along with this but theres a new issue building QML with bitcoin core as a subtree. From ChatGPT:
from the compiler: |
- This introduce the UI flow to load a AssumeUTXO snapshot - It modifies the connection settings - Adds a SnapshotLoadSettings file, Icon, and modified progress bar. - Also it adds error page on snapshotloading failure
-Also pointing url to D33r-Gee /bitcoin repository
D33r-Gee
force-pushed
the
alt-qml-snapshotload
branch
2 times, most recently
from
c42ad64 to
72c1458
Compare
Addresses multiple compilation and runtime issues introduced by incoming interface updates: - qml/bitcoin.cpp: Update ThreadSafeMessageBox UI callback signature and switch LogPrintf to LogInfo. - qml/models/chainmodel.cpp: Avoid calling getBlockHash on a hardcoded snapshot height that is not yet locally fetched; use AssumeutxoData.blockhash natively to prevent out-of-bound crashes. - qml/models/chainmodel.h: Guard out chain headers with Q_MOC_RUN to avoid standard-concept parser errors inside QT automoc. - qml/models/options_model.cpp: Add inline SettingToInt/SettingToBool helpers to operate safely over common::SettingsValue. - qml/models/peerdetailsmodel.h: Fallback to the new presync_height field dynamically inside CNodeStateStats as m_starting_height has been deprecated. - qml/models/walletqmlmodel.cpp: Supply std::nullopt to correctly satisfy the modernized interfaces::Wallet::createTransaction 4-argument parameters interface. - qml/models/transaction.cpp & walletqmlmodel.cpp: Drop obsolete uint256::FromUint256 wrappers in favor of executing the respective Txid.ToUint256() functionality. - qml/peerstatsutil.cpp: Add missing PRIVATE_BROADCAST enum handling inside ConnectionTypeToQString mapping. - test/mocks/mocknode.h: Update getProxy signature and insert missing snapshot & handleSnapshotLoadProgress mock definitions. - qml/walletqmlcontroller.cpp: Provide true for the trailing `load_after_restore` argument on interfaces::WalletLoader::restoreWallet. - qml/models/walletqmlmodel.cpp: Drop trailing nullptr (purpose) as the updated interfaces::Wallet::getAddress now strictly asks for 3 parameters.
D33r-Gee
force-pushed
the
alt-qml-snapshotload
branch
from
72c1458 to
a904558
Compare
|
with a904558 addressed the rebasing upstream issues that @pinheadmz brought up (Thanks for that) Also added a commit to address the discrepancies between the qt6 submodule branch and upstream. Regarding the macos-14 CLI failure, not quite sure how to address that? |
2 participants
This is an re-opened PR based on #424 and #449. It's an alternate to #485 that uses a different /bitcoin branch instead of a patch.
UTXO Snapshot Loading
Overview
This PR enables loading UTXO snapshots both during and after the initial onboarding process.
What This PR Does
Implementation Details
Core Components Modified
qml/models/nodemodel.cpp)qml/components/SnapshotLoadSettings.qml,src/qml/components/ConnectionSettings.qml)Key Design Decisions
Testing Instructions
Test onboarding flow:
Verify (see screenshots below):
Ubuntu 22.04 Screenshots
Expected Behavior
Success/failure state properly displayed
feedback welcome on the approach and implementation details.