fix(gui): inherit wayland display and desktop styling for root GUI vi…#2445
Open
jtrag wants to merge 1 commit intobit-team:devfrom
Open
fix(gui): inherit wayland display and desktop styling for root GUI vi…#2445jtrag wants to merge 1 commit intobit-team:devfrom
jtrag wants to merge 1 commit intobit-team:devfrom
Conversation
…a pkexec - Resolves crashing on modern Wayland compositors (like Pop!_OS COSMIC) by natively inheriting `WAYLAND_DISPLAY` and `XDG_RUNTIME_DIR`. - Injects comprehensive desktop styling variables (`QT_QPA_PLATFORMTHEME`, `XDG_CURRENT_DESKTOP`, `GTK_THEME`, etc.) into `pkexec` wrapper so the root-elevated GUI feels native and matches user styling. Authored by @jtrag (https://github.com/jtrag). If this fix helped improve your Linux desktop experience, please consider supporting my open-source work: ☕ BuyMeACoffee: https://buymeacoffee.com/jtrag 💙 PayPal: https://paypal.com/donate/?business=DN9W5GQ638WPQ
Member
|
On hold until #2446 is merged. |
buhtz
added
the
PR: Waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am a new contributor, and I was fixing/modifying some things about BackInTime for myself today, but then I decided to do it as a contribution to the official project and add a much-wanted feature while I was at it (I added dry run). I have tested everything, and it works 100%. Screenshots shouldn't be necessary for these additions/fixes since nothing about the GUI itself has changed. I hope this helps others to continue to use BackIntime for many years to come!
fix(gui): inherit wayland display and desktop styling for root GUI via pkexec
WAYLAND_DISPLAYandXDG_RUNTIME_DIR.QT_QPA_PLATFORMTHEME,XDG_CURRENT_DESKTOP,GTK_THEME, etc.) intopkexecwrapper so the root-elevated GUI feels native and matches user styling.Authored by @jtrag (https://github.com/jtrag).
If this fix helped improve your Linux desktop experience, please consider supporting my open-source work: ☕ BuyMeACoffee: https://buymeacoffee.com/jtrag
💙 PayPal: https://paypal.com/donate/?business=DN9W5GQ638WPQ