Conversation
Captures the alias of Obsidian links if it exists. e.g.: [[My note|A special note]] becomes A special note, if removeOutgoingLinkBrackets is activated.
inspired from ATTACHMENT_URL_REGEXP
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)✅ Unit Test PR creation complete.
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fixes #124 created as a draft until last edge case solution chosen |
|
I've tested a new regex that will handle all three cases : If we change the
If the last case above is not what you want, we just need to remove the |
|
@Nicendredi ready for review ? |
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
❌ Failed to create PR with unit tests: AGENT_CHAT: Failed to open pull request |
Captures the alias of Obsidian links if it exists. e.g.:
[[My note|A special note]]becomesA special note, ifremoveOutgoingLinkBracketsis activated.Tested locally on my Obsidian vault with a note containing the following types of links :
[[My note]]->My note[[My note|A special note]]->A special note[A special note](../folder/My%20note.md)->[A special note](../folder/My%20note.md)As seen in the example, there is still a problem with Markdown-style links in the original note. The rule to handle this edge case will be quite complicated to implement, if you want links to external URLs to be correctly exported, but links to Obsidian Vault files to be handled in the same way as the first two link styles.
Proposed solutions for the last edge case :