Add constexpr attribute to operator std::basic_string_view#20
Closed
matan7890 wants to merge 1 commit intobemanproject:mainfrom
Closed
Add constexpr attribute to operator std::basic_string_view#20matan7890 wants to merge 1 commit intobemanproject:mainfrom
matan7890 wants to merge 1 commit intobemanproject:mainfrom
Conversation
Although the RFC doesn't mention it, there is no reason for this operator to not be constexpr, at least from c++20 and later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the operator constexpr (available since C++20). While not explicitly mentioned in the RFC, there appears to be no reason to prevent compile-time usage, and this matches the behavior of similar standard library operators.
If strict adherence to P3655R2 is preferred, feel free to close this PR — I’m submitting it mainly for future reference.