Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/abstractions/pod/proxy.go">
<violation number="1" location="pkg/abstractions/pod/proxy.go:331">
P2: The custom proxy `ErrorHandler` logs errors but never returns an HTTP error response to the client.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Simplified the pod proxy by removing the custom Gorilla WebSocket intercept and routing all traffic through
httputil.NewSingleHostReverseProxy. WebSocket and streaming are now handled by the standard reverse proxy with proper timeouts, immediate flushing, and 502 responses on backend errors.httputil.NewSingleHostReverseProxyfor HTTP and WebSocket.FlushInterval = -1for immediate flushing (SSE/streaming).proxy.ErrorHandlerto log and return 502 Bad Gateway on proxy errors.DialContext.Written for commit 610b641. Summary will update on new commits.