fix: 봇 로직 P0-P2 수정, API 인증, 네비게이션 및 벌금 알림 개선#44
Merged
Conversation
- WeeklyRanking: runningLock 제거, isRunning 단순 가드로 교체 (P0) - RoundReporter: sendRoundStartAnnouncement에 isRunning 가드 추가 (P0) - FineReminder: 3일→1일 리마인드 간격 변경, logger 전환, isRunning 가드 - bot-operations route: AbortError 타임아웃 처리, URL 파싱 수정 - bot-operation-card: 내부 로딩 상태 제거, 부모 prop만 사용 - api-server: round-start에 isReporting 가드 추가 - scheduler-registry: curation-share 크론 5분 오프셋 (충돌 방지) - sidebar/bottom-nav: 관리자 '봇' 탭 추가, 하단 네비 관리자 모드 6탭 - shared: formatKSTDate를 date-utils에 추가 (Intl 타임존) - 문서 업데이트: CLAUDE.md, patterns.md, ARCHITECTURE.md Co-Authored-By: Claude <noreply@anthropic.com>
- api-server: BOT_API_SECRET Bearer 토큰 인증 미들웨어 추가 (P0) - api-server: express.json limit 10kb, 500 에러 메시지 제네릭화 (P1) - bot-operations proxy: Authorization 헤더 전송, 에러 메시지 새니타이즈 (P0/P1) - .env.example: BOT_API_SECRET, BOT_API_URL 추가 Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
봇 스케줄러 로직 리뷰에서 발견된 P0-P2 이슈 전체 수정 + 보안 리뷰 P0(API 인증) 해결 + 관리자 네비게이션 업데이트 + 벌금 알림 일일 변경.
Changes
봇 로직 수정 (P0-P2)
weekly-ranking.tsrunningLock제거 →isRunning단순 가드 (P0)round-reporter.tssendRoundStartAnnouncement에isRunning가드 + finally 추가 (P0)fine-reminder.tsapi-server.tsdate-utils.tsformatKSTDate공유 유틸 추가 (Intl 타임존)보안 수정 (P0)
api-server.tsBOT_API_SECRETBearer 토큰 인증 미들웨어 추가,express.json({ limit: '10kb' }), 500 에러 제네릭화[operationId]/route.tsAuthorization헤더 전송, 에러 메시지 새니타이즈, AbortError 처리.env.exampleBOT_API_SECRET,BOT_API_URL추가UI/네비게이션
sidebar.tsxbottom-nav.tsxbot-operation-card.tsxbot-operations/route.ts문서
CLAUDE.mddocs/26-03-06-patterns.mddocs/ARCHITECTURE.mdDesign Decisions
runningLock제거 →isRunningBOT_API_SECRETBearer 인증Test Plan
BOT_API_SECRET미설정 시 401 반환 확인BOT_API_SECRET설정 후 정상 트리거 확인.env에BOT_API_SECRET추가 필요packages/web/.env.local에BOT_API_SECRET+BOT_API_URL추가 필요🤖 Generated with Claude Code