Updated code from #116 to get it merged.#190
Open
cocampbe wants to merge 1 commit intobaztian:masterfrom
Open
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Author
|
Good, bad, ugly? |
Owner
|
Thanks @cocampbe it actually looks good to me. Unfortunately I'm having issues with the Jython builds. But this is not due to one of your changes but to some incompatibilities introduces in some lib used during build. So I'm wondering if I finally should drop Jython support. |
|
Hey @baztian, my team also need the ability to specify Java options. Seems like this feature is frequently requested by consumers of JayDeBeAPI as there has been number of pull request for this (#116 and #166) If this change looks good, could you merge the pull request and publish a new version, please? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really need ability to pass java_opts. I saw #116 and decided to make the corrections.