Fix HTTP session inefficiency by sharing MultiIndexRunner across sessions#16
Open
augment-app-staging[bot] wants to merge 1 commit intomainfrom
Open
Fix HTTP session inefficiency by sharing MultiIndexRunner across sessions#16augment-app-staging[bot] wants to merge 1 commit intomainfrom
augment-app-staging[bot] wants to merge 1 commit intomainfrom
Conversation
…ions - Add optional 'runner' parameter to MCPServerConfig interface - Update createMCPServer() to accept and use optional runner parameter - Create shared MultiIndexRunner in HTTP server initialization - Pass shared runner to each per-session createMCPServer() call - Add comments explaining User-Agent update behavior with shared runner - Maintain backward compatibility (runner parameter is optional) - All existing tests pass This avoids redundant store.list() + store.loadSearch() calls for every HTTP session, which is especially wasteful for S3-backed stores. Related: https://slack.com/archives/C0ACX5SLML7/p1770850068455299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently in
src/clients/mcp-http-server.ts, every new HTTP client session creates a fresh MultiIndexRunner instance via createMCPServer(). This causes redundant store.list() + store.loadSearch() calls for every index on every session, which is wasteful especially for S3-backed stores.Solution
Share a single MultiIndexRunner instance across all HTTP sessions while maintaining per-session MCP Server instances (required by MCP protocol).
Changes
Modified
src/clients/mcp-server.ts:runner?: MultiIndexRunnerparameter to theMCPServerConfiginterfacecreateMCPServer()function to:updateClientUserAgent()call in theoninitializedcallback will update the shared runner for all sessions (last writer wins), and that this is intentional behaviorModified
src/clients/mcp-http-server.ts:createMCPHttpServer()function, create a single shared MultiIndexRunner instance during server initialization (before the session handling logic)createMCPServer()callTesting
Key Benefits
Notes
updateClientUserAgent()behavior in theoninitializedcallback will affect all sessions when using a shared runner (last writer wins). This is acceptable and documented with a comment.Related: https://slack.com/archives/C0ACX5SLML7/p1770850068455299