feat: dismissal and acceptWord commands#62
Open
alvaromrveiga wants to merge 1 commit intoaugmentcode:mainfrom
Open
feat: dismissal and acceptWord commands#62alvaromrveiga wants to merge 1 commit intoaugmentcode:mainfrom
alvaromrveiga wants to merge 1 commit intoaugmentcode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I was missing being able to accept only a few words of the suggestion and also dismissing it when it is not relevant, hope this helps other people too.
augment.webm
Changes
This pull requests exposes
augment#suggestion#Clear()as a public API that can be called asaugment#Dismissand create the new commandaugment#AcceptWord()it accepts a fallback just likeaugment#Acceptdoes.Here is an example on how I configured those keys in Neovim using lazy.nvim:
In case someone else needs it, I use nvim-cmp for completions so this change was needed in my config so it does not get in the way of suggestions:
Testing
Verified that augment#AcceptWord() correctly moves the cursor and accepts only the next word of the ghost text.
Confirmed augment#Dismiss() clears the current suggestion UI immediately.