This repository was archived by the owner on Jan 1, 2024. It is now read-only.
Change after_fork suggestion to before_fork#47
Open
aripollak wants to merge 2 commits intoassaf:masterfrom
aripollak:patch-1
Open
Change after_fork suggestion to before_fork#47aripollak wants to merge 2 commits intoassaf:masterfrom aripollak:patch-1
aripollak wants to merge 2 commits intoassaf:masterfrom
aripollak:patch-1
Conversation
Author
|
Any comment on this? We've had a couple of UUID collisions out of 18 million rows, which I believe is caused by this bug since the duplicated UUIDs were generated at the same time. |
Author
|
Also, for Puma, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing it in the worker process won't have the desired effect since then all the workers all get the same incremented sequence number.
before_forkruns in the master process before the fork, so the new sequence number gets inherited in each worker.